Implement in-memory test harness for IRC Events REST endpoint#14929
Closed
Jayesh45-master wants to merge 1 commit intoapache:mainfrom
Closed
Implement in-memory test harness for IRC Events REST endpoint#14929Jayesh45-master wants to merge 1 commit intoapache:mainfrom
Jayesh45-master wants to merge 1 commit intoapache:mainfrom
Conversation
3 tasks
RussellSpitzer
changed the title
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement in-memory test harness for IRC Events REST endpoint
Fixes #13582
Summary
This PR introduces a lightweight test harness for the IRC Events REST endpoint in the Iceberg REST Catalog.
The implementation is intentionally non-production, using an in-memory event store, and is designed to unblock further development and validation of the Events API before it is merged into the REST Catalog specification.
This work follows the consensus reached in #12584 and builds on the groundwork from #13580.
Motivation
Before finalizing and merging the IRC Events endpoint into the REST Catalog specification, we need a concrete implementation to:
Validate endpoint contracts
Enable integration and unit testing
Provide a reference implementation for future production backends
The test harness satisfies these needs without introducing storage or operational complexity.
What’s Included
This PR adds support for POST and GET operations on:
using an in-memory backend.
Key components introduced
In-memory events store
Thread-safe storage for received events
Suitable for tests and local development only
Request / response models
PostEventsRequestEventsResponseREST wiring
New routes registered in
RouteEndpoint handling added to
RESTCatalogAdapterPath helpers
Centralized
/v1/{prefix}/eventspath inResourcePathsTests
TestEventsEndpointvalidates:Posting events
Retrieving stored events
Basic request/response flow
Files Changed
Design Notes
Non-production by design
The in-memory store is scoped to testing and local usage only.
No persistence guarantees
Events are not durable and reset between runs.
Minimal surface area
No external dependencies or configuration required.
This approach keeps the implementation simple while providing meaningful coverage and validation.
Testing
Added
TestEventsEndpointVerified:
POST events are accepted
GET returns previously posted events
Full build executed locally using:
Backward Compatibility
No breaking changes
No impact on existing REST Catalog functionality
New endpoint is additive and isolated
Follow-ups / Future Work
Pluggable or persistent event stores
Metrics and retention policies
Authorization and filtering
Production-ready implementations
Checklist
Follows Iceberg REST patterns
Minimal, test-only implementation
Covered by unit tests
No production assumptions introduced
Ready for review and iteration